1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
|
/******************************************************************************
* Copyright (C) 2015 Felix Rohrbach <kde@fxrh.de>
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
#include "basejob.h"
#include "connectiondata.h"
#include "util.h"
#include <QtNetwork/QNetworkAccessManager>
#include <QtNetwork/QNetworkRequest>
#include <QtNetwork/QNetworkReply>
#include <QtCore/QTimer>
#include <QtCore/QRegularExpression>
#include <QtCore/QJsonObject>
#include <array>
using namespace QMatrixClient;
struct NetworkReplyDeleter : public QScopedPointerDeleteLater
{
static inline void cleanup(QNetworkReply* reply)
{
if (reply && reply->isRunning())
reply->abort();
QScopedPointerDeleteLater::cleanup(reply);
}
};
class BaseJob::Private
{
public:
// Using an idiom from clang-tidy:
// http://clang.llvm.org/extra/clang-tidy/checks/modernize-pass-by-value.html
Private(HttpVerb v, QString endpoint, const QUrlQuery& q,
Data&& data, bool nt)
: verb(v), apiEndpoint(std::move(endpoint)), requestQuery(q)
, requestData(std::move(data)), needsToken(nt)
{ }
void sendRequest(bool inBackground);
const JobTimeoutConfig& getCurrentTimeoutConfig() const;
const ConnectionData* connection = nullptr;
// Contents for the network request
HttpVerb verb;
QString apiEndpoint;
QHash<QByteArray, QByteArray> requestHeaders;
QUrlQuery requestQuery;
Data requestData;
bool needsToken;
// There's no use of QMimeType here because we don't want to match
// content types against the known MIME type hierarchy; and at the same
// type QMimeType is of little help with MIME type globs (`text/*` etc.)
QByteArrayList expectedContentTypes;
QScopedPointer<QNetworkReply, NetworkReplyDeleter> reply;
Status status = Pending;
QByteArray rawResponse;
QUrl errorUrl; //< May contain a URL to help with some errors
QTimer timer;
QTimer retryTimer;
QVector<JobTimeoutConfig> errorStrategy =
{ { 90, 5 }, { 90, 10 }, { 120, 30 } };
int maxRetries = errorStrategy.size();
int retriesTaken = 0;
LoggingCategory logCat = JOBS;
};
BaseJob::BaseJob(HttpVerb verb, const QString& name, const QString& endpoint, bool needsToken)
: BaseJob(verb, name, endpoint, Query { }, Data { }, needsToken)
{ }
BaseJob::BaseJob(HttpVerb verb, const QString& name, const QString& endpoint,
const Query& query, Data&& data, bool needsToken)
: d(new Private(verb, endpoint, query, std::move(data), needsToken))
{
setObjectName(name);
setExpectedContentTypes({ "application/json" });
d->timer.setSingleShot(true);
connect (&d->timer, &QTimer::timeout, this, &BaseJob::timeout);
}
BaseJob::~BaseJob()
{
stop();
qCDebug(d->logCat) << this << "destroyed";
}
QUrl BaseJob::requestUrl() const
{
return d->reply ? d->reply->request().url() : QUrl();
}
bool BaseJob::isBackground() const
{
return d->reply && d->reply->request().attribute(
QNetworkRequest::BackgroundRequestAttribute).toBool();
}
const QString& BaseJob::apiEndpoint() const
{
return d->apiEndpoint;
}
void BaseJob::setApiEndpoint(const QString& apiEndpoint)
{
d->apiEndpoint = apiEndpoint;
}
const BaseJob::headers_t&BaseJob::requestHeaders() const
{
return d->requestHeaders;
}
void BaseJob::setRequestHeader(const headers_t::key_type& headerName,
const headers_t::mapped_type& headerValue)
{
d->requestHeaders[headerName] = headerValue;
}
void BaseJob::setRequestHeaders(const BaseJob::headers_t& headers)
{
d->requestHeaders = headers;
}
const QUrlQuery& BaseJob::query() const
{
return d->requestQuery;
}
void BaseJob::setRequestQuery(const QUrlQuery& query)
{
d->requestQuery = query;
}
const BaseJob::Data& BaseJob::requestData() const
{
return d->requestData;
}
void BaseJob::setRequestData(Data&& data)
{
std::swap(d->requestData, data);
}
const QByteArrayList& BaseJob::expectedContentTypes() const
{
return d->expectedContentTypes;
}
void BaseJob::addExpectedContentType(const QByteArray& contentType)
{
d->expectedContentTypes << contentType;
}
void BaseJob::setExpectedContentTypes(const QByteArrayList& contentTypes)
{
d->expectedContentTypes = contentTypes;
}
QUrl BaseJob::makeRequestUrl(QUrl baseUrl,
const QString& path, const QUrlQuery& query)
{
auto pathBase = baseUrl.path();
if (!pathBase.endsWith('/') && !path.startsWith('/'))
pathBase.push_back('/');
baseUrl.setPath(pathBase + path, QUrl::TolerantMode);
baseUrl.setQuery(query);
return baseUrl;
}
void BaseJob::Private::sendRequest(bool inBackground)
{
QNetworkRequest req
{ makeRequestUrl(connection->baseUrl(), apiEndpoint, requestQuery) };
if (!requestHeaders.contains("Content-Type"))
req.setHeader(QNetworkRequest::ContentTypeHeader, "application/json");
req.setRawHeader("Authorization",
QByteArray("Bearer ") + connection->accessToken());
req.setAttribute(QNetworkRequest::BackgroundRequestAttribute, inBackground);
#if (QT_VERSION >= QT_VERSION_CHECK(5, 6, 0))
req.setAttribute(QNetworkRequest::FollowRedirectsAttribute, true);
req.setMaximumRedirectsAllowed(10);
#endif
req.setAttribute(QNetworkRequest::HttpPipeliningAllowedAttribute, true);
#if QT_VERSION >= QT_VERSION_CHECK(5, 9, 0)
// some sources claim that there are issues with QT 5.8
req.setAttribute(QNetworkRequest::HTTP2AllowedAttribute, true);
#endif
for (auto it = requestHeaders.cbegin(); it != requestHeaders.cend(); ++it)
req.setRawHeader(it.key(), it.value());
switch( verb )
{
case HttpVerb::Get:
reply.reset( connection->nam()->get(req) );
break;
case HttpVerb::Post:
reply.reset( connection->nam()->post(req, requestData.source()) );
break;
case HttpVerb::Put:
reply.reset( connection->nam()->put(req, requestData.source()) );
break;
case HttpVerb::Delete:
reply.reset( connection->nam()->deleteResource(req) );
break;
}
}
void BaseJob::beforeStart(const ConnectionData*)
{ }
void BaseJob::afterStart(const ConnectionData*, QNetworkReply*)
{ }
void BaseJob::beforeAbandon(QNetworkReply*)
{ }
void BaseJob::start(const ConnectionData* connData, bool inBackground)
{
d->connection = connData;
d->retryTimer.setSingleShot(true);
connect (&d->retryTimer, &QTimer::timeout,
this, [this,inBackground] { sendRequest(inBackground); });
beforeStart(connData);
if (status().good())
sendRequest(inBackground);
if (status().good())
afterStart(connData, d->reply.data());
if (!status().good())
QTimer::singleShot(0, this, &BaseJob::finishJob);
}
void BaseJob::sendRequest(bool inBackground)
{
emit aboutToStart();
d->retryTimer.stop(); // In case we were counting down at the moment
qCDebug(d->logCat) << this << "sending request to" << d->apiEndpoint;
if (!d->requestQuery.isEmpty())
qCDebug(d->logCat) << " query:" << d->requestQuery.toString();
d->sendRequest(inBackground);
connect( d->reply.data(), &QNetworkReply::finished, this, &BaseJob::gotReply );
if (d->reply->isRunning())
{
connect( d->reply.data(), &QNetworkReply::metaDataChanged,
this, &BaseJob::checkReply);
connect( d->reply.data(), &QNetworkReply::uploadProgress,
this, &BaseJob::uploadProgress);
connect( d->reply.data(), &QNetworkReply::downloadProgress,
this, &BaseJob::downloadProgress);
d->timer.start(getCurrentTimeout());
qCDebug(d->logCat) << this << "request has been sent";
emit started();
}
else
qCWarning(d->logCat) << this << "request could not start";
}
void BaseJob::checkReply()
{
setStatus(doCheckReply(d->reply.data()));
}
void BaseJob::gotReply()
{
checkReply();
if (status().good())
setStatus(parseReply(d->reply.data()));
else {
// FIXME: Factor out to smth like BaseJob::handleError()
d->rawResponse = d->reply->readAll();
const auto jsonBody =
d->reply->rawHeader("Content-Type") == "application/json";
qCDebug(d->logCat).noquote()
<< "Error body (truncated if long):" << d->rawResponse.left(500);
if (jsonBody)
{
auto json = QJsonDocument::fromJson(d->rawResponse).object();
const auto errCode = json.value("errcode"_ls).toString();
if (error() == TooManyRequestsError ||
errCode == "M_LIMIT_EXCEEDED")
{
QString msg = tr("Too many requests");
auto retryInterval = json.value("retry_after_ms"_ls).toInt(-1);
if (retryInterval != -1)
msg += tr(", next retry advised after %1 ms")
.arg(retryInterval);
else // We still have to figure some reasonable interval
retryInterval = getNextRetryInterval();
setStatus(TooManyRequestsError, msg);
// Shortcut to retry instead of executing finishJob()
stop();
qCWarning(d->logCat)
<< this << "will retry in" << retryInterval << "ms";
d->retryTimer.start(retryInterval);
emit retryScheduled(d->retriesTaken, retryInterval);
return;
}
if (errCode == "M_CONSENT_NOT_GIVEN")
{
d->status.code = UserConsentRequiredError;
d->errorUrl = json.value("consent_uri"_ls).toString();
}
else if (errCode == "M_UNSUPPORTED_ROOM_VERSION" ||
errCode == "M_INCOMPATIBLE_ROOM_VERSION")
{
d->status.code = UnsupportedRoomVersionError;
if (json.contains("room_version"))
d->status.message =
tr("Requested room version: %1")
.arg(json.value("room_version").toString());
}
else if (errCode == "M_CANNOT_LEAVE_SERVER_NOTICE_ROOM")
setStatus(IncorrectRequestError,
tr("It's not allowed to leave a server notices room"));
else if (!json.isEmpty()) // Not localisable on the client side
setStatus(d->status.code, json.value("error"_ls).toString());
}
}
finishJob();
}
bool checkContentType(const QByteArray& type, const QByteArrayList& patterns)
{
if (patterns.isEmpty())
return true;
// ignore possible appendixes of the content type
const auto ctype = type.split(';').front();
for (const auto& pattern: patterns)
{
if (pattern.startsWith('*') || ctype == pattern) // Fast lane
return true;
auto patternParts = pattern.split('/');
Q_ASSERT_X(patternParts.size() <= 2, __FUNCTION__,
"BaseJob: Expected content type should have up to two"
" /-separated parts; violating pattern: " + pattern);
if (ctype.split('/').front() == patternParts.front() &&
patternParts.back() == "*")
return true; // Exact match already went on fast lane
}
return false;
}
BaseJob::Status BaseJob::doCheckReply(QNetworkReply* reply) const
{
// QNetworkReply error codes seem to be flawed when it comes to HTTP;
// see, e.g., https://github.com/QMatrixClient/libqmatrixclient/issues/200
// so check genuine HTTP codes. The below processing is based on
// https://en.wikipedia.org/wiki/List_of_HTTP_status_codes
const auto httpCodeHeader =
reply->attribute(QNetworkRequest::HttpStatusCodeAttribute);
if (!httpCodeHeader.isValid())
{
qCWarning(d->logCat) << this << "didn't get valid HTTP headers";
return { NetworkError, reply->errorString() };
}
const QString replyState = reply->isRunning() ?
QStringLiteral("(tentative)") : QStringLiteral("(final)");
const auto urlString = '|' + d->reply->url().toDisplayString();
const auto httpCode = httpCodeHeader.toInt();
const auto reason =
reply->attribute(QNetworkRequest::HttpReasonPhraseAttribute).toString();
if (httpCode / 100 == 2) // 2xx
{
qCDebug(d->logCat).noquote().nospace() << this << urlString;
qCDebug(d->logCat).noquote() << " " << httpCode << reason << replyState;
if (!checkContentType(reply->rawHeader("Content-Type"),
d->expectedContentTypes))
return { UnexpectedResponseTypeWarning,
"Unexpected content type of the response" };
return NoError;
}
qCWarning(d->logCat).noquote().nospace() << this << urlString;
qCWarning(d->logCat).noquote() << " " << httpCode << reason << replyState;
return { [httpCode]() -> StatusCode {
if (httpCode / 10 == 41)
return httpCode == 410 ? IncorrectRequestError : NotFoundError;
switch (httpCode)
{
case 401: case 403: case 407:
return ContentAccessError;
case 404:
return NotFoundError;
case 400: case 405: case 406: case 426: case 428:
case 505:
case 494: // Unofficial nginx "Request header too large"
case 497: // Unofficial nginx "HTTP request sent to HTTPS port"
return IncorrectRequestError;
case 429:
return TooManyRequestsError;
case 501: case 510:
return RequestNotImplementedError;
case 511:
return NetworkAuthRequiredError;
default:
return NetworkError;
}
}(), reply->errorString() };
}
BaseJob::Status BaseJob::parseReply(QNetworkReply* reply)
{
d->rawResponse = reply->readAll();
QJsonParseError error { 0, QJsonParseError::MissingObject };
const auto& json = QJsonDocument::fromJson(d->rawResponse, &error);
if( error.error == QJsonParseError::NoError )
return parseJson(json);
return { IncorrectResponseError, error.errorString() };
}
BaseJob::Status BaseJob::parseJson(const QJsonDocument&)
{
return Success;
}
void BaseJob::stop()
{
d->timer.stop();
if (d->reply)
{
d->reply->disconnect(this); // Ignore whatever comes from the reply
if (d->reply->isRunning())
{
qCWarning(d->logCat) << this << "stopped without ready network reply";
d->reply->abort();
}
}
else
qCWarning(d->logCat) << this << "stopped with empty network reply";
}
void BaseJob::finishJob()
{
stop();
if ((error() == NetworkError || error() == TimeoutError)
&& d->retriesTaken < d->maxRetries)
{
// TODO: The whole retrying thing should be put to ConnectionManager
// otherwise independently retrying jobs make a bit of notification
// storm towards the UI.
const auto retryInterval =
error() == TimeoutError ? 0 : getNextRetryInterval();
++d->retriesTaken;
qCWarning(d->logCat).nospace() << this << ": retry #" << d->retriesTaken
<< " in " << retryInterval/1000 << " s";
d->retryTimer.start(retryInterval);
emit retryScheduled(d->retriesTaken, retryInterval);
return;
}
// Notify those interested in any completion of the job (including killing)
emit finished(this);
emit result(this);
if (error())
emit failure(this);
else
emit success(this);
deleteLater();
}
const JobTimeoutConfig& BaseJob::Private::getCurrentTimeoutConfig() const
{
return errorStrategy[std::min(retriesTaken, errorStrategy.size() - 1)];
}
BaseJob::duration_t BaseJob::getCurrentTimeout() const
{
return d->getCurrentTimeoutConfig().jobTimeout * 1000;
}
BaseJob::duration_t BaseJob::getNextRetryInterval() const
{
return d->getCurrentTimeoutConfig().nextRetryInterval * 1000;
}
BaseJob::duration_t BaseJob::millisToRetry() const
{
return d->retryTimer.isActive() ? d->retryTimer.remainingTime() : 0;
}
int BaseJob::maxRetries() const
{
return d->maxRetries;
}
void BaseJob::setMaxRetries(int newMaxRetries)
{
d->maxRetries = newMaxRetries;
}
BaseJob::Status BaseJob::status() const
{
return d->status;
}
QByteArray BaseJob::rawData(int bytesAtMost) const
{
return bytesAtMost > 0 && d->rawResponse.size() > bytesAtMost
? d->rawResponse.left(bytesAtMost) : d->rawResponse;
}
QString BaseJob::rawDataSample(int bytesAtMost) const
{
auto data = rawData(bytesAtMost);
Q_ASSERT(data.size() <= d->rawResponse.size());
return data.size() == d->rawResponse.size()
? data : data + tr("...(truncated, %Ln bytes in total)",
"Comes after trimmed raw network response",
d->rawResponse.size());
}
QString BaseJob::statusCaption() const
{
switch (d->status.code)
{
case Success:
return tr("Success");
case Pending:
return tr("Request still pending response");
case UnexpectedResponseTypeWarning:
return tr("Warning: Unexpected response type");
case Abandoned:
return tr("Request was abandoned");
case NetworkError:
return tr("Network problems");
case JsonParseError:
return tr("Response could not be parsed");
case TimeoutError:
return tr("Request timed out");
case ContentAccessError:
return tr("Access error");
case NotFoundError:
return tr("Not found");
case IncorrectRequestError:
return tr("Invalid request");
case IncorrectResponseError:
return tr("Response could not be parsed");
case TooManyRequestsError:
return tr("Too many requests");
case RequestNotImplementedError:
return tr("Function not implemented by the server");
case NetworkAuthRequiredError:
return tr("Network authentication required");
case UserConsentRequiredError:
return tr("User consent required");
case UnsupportedRoomVersionError:
return tr("The server does not support the needed room version");
default:
return tr("Request failed");
}
}
int BaseJob::error() const
{
return d->status.code;
}
QString BaseJob::errorString() const
{
return d->status.message;
}
QUrl BaseJob::errorUrl() const
{
return d->errorUrl;
}
void BaseJob::setStatus(Status s)
{
// The crash that led to this code has been reported in
// https://github.com/QMatrixClient/Quaternion/issues/566 - basically,
// when cleaning up childrent of a deleted Connection, there's a chance
// of pending jobs being abandoned, calling setStatus(Abandoned).
// There's nothing wrong with this; however, the safety check for
// cleartext access tokens below uses d->connection - which is a dangling
// pointer.
// To alleviate that, a stricter condition is applied, that for Abandoned
// and to-be-Abandoned jobs the status message will be disregarded entirely.
// For 0.6 we might rectify the situation by making d->connection
// a QPointer<> (and derive ConnectionData from QObject, respectively).
if (d->status.code == Abandoned || s.code == Abandoned)
s.message.clear();
if (d->status == s)
return;
if (!s.message.isEmpty()
&& d->connection && !d->connection->accessToken().isEmpty())
s.message.replace(d->connection->accessToken(), "(REDACTED)");
if (!s.good())
qCWarning(d->logCat) << this << "status" << s;
d->status = std::move(s);
emit statusChanged(d->status);
}
void BaseJob::setStatus(int code, QString message)
{
setStatus({ code, std::move(message) });
}
void BaseJob::abandon()
{
beforeAbandon(d->reply ? d->reply.data() : nullptr);
setStatus(Abandoned);
if (d->reply)
d->reply->disconnect(this);
emit finished(this);
deleteLater();
}
void BaseJob::timeout()
{
setStatus( TimeoutError, "The job has timed out" );
finishJob();
}
void BaseJob::setLoggingCategory(LoggingCategory lcf)
{
d->logCat = lcf;
}
|