diff options
| author | Kitsune Ral <Kitsune-Ral@users.sf.net> | 2021-01-07 20:16:59 +0100 |
|---|---|---|
| committer | Kitsune Ral <Kitsune-Ral@users.sf.net> | 2021-01-07 20:16:59 +0100 |
| commit | 90d41b697af39253483d9bcca4e57b11d2197112 (patch) | |
| tree | ca715e5f115658711239e0fce6286b292ff221b7 /tests | |
| parent | 9c8966b094a838fb72a46c1068d9d6f88c3795c2 (diff) | |
| download | libquotient-90d41b697af39253483d9bcca4e57b11d2197112.tar.gz libquotient-90d41b697af39253483d9bcca4e57b11d2197112.zip | |
Prefer connecting to BaseJob::result(), not finished()
...because finished() includes abandoning and should only be relevant
when lifecycle issues are involved.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/quotest.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/quotest.cpp b/tests/quotest.cpp index edf0e014..a1c13ae1 100644 --- a/tests/quotest.cpp +++ b/tests/quotest.cpp @@ -831,7 +831,7 @@ void TestManager::conclude() // .then(this, &TestManager::finalize); // Qt-style or // .then([this] { finalize(); }); // STL-style auto* job = room->leaveRoom(); - connect(job, &BaseJob::finished, this, [this, job,plainReport] { + connect(job, &BaseJob::result, this, [this, job,plainReport] { Q_ASSERT(job->status().good()); finalize(); // Still flying, as the exit() connection in finalize() is queued |