Fix Omittables accidentally becoming non-omitted when compared with non-Omittable values

1 files changed, 20 insertions, 1 deletions

diff --git a/lib/util.h b/lib/util.h
index 336248d3..77c2bfdb 100644
--- a/lib/util.h
+++ b/lib/util.h
@@ -107,6 +107,25 @@ namespace QMatrixClient
                 return *this;
             }
 
+            bool operator==(const value_type& rhs) const
+            {
+                return !omitted() && value() == rhs;
+            }
+            friend bool operator==(const value_type& lhs,
+                                   const Omittable<value_type>& rhs)
+            {
+                return rhs == lhs;
+            }
+            bool operator!=(const value_type& rhs) const
+            {
+                return !operator==(rhs);
+            }
+            friend bool operator!=(const value_type& lhs,
+                                   const Omittable<value_type>& rhs)
+            {
+                return !(rhs == lhs);
+            }
+
             bool omitted() const { return _omitted; }
             const value_type& value() const
             {
@@ -136,7 +155,7 @@ namespace QMatrixClient
             }
             value_type&& release() { _omitted = true; return std::move(_value); }
 
-            operator value_type&() & { return editValue(); }
+            operator const value_type&() const & { return value(); }
             const value_type* operator->() const & { return &value(); }
             value_type* operator->() & { return &editValue(); }
             const value_type& operator*() const & { return value(); }