diff options
| author | Alexey Rusakov <Kitsune-Ral@users.sf.net> | 2022-01-02 06:03:26 +0100 |
|---|---|---|
| committer | Alexey Rusakov <Kitsune-Ral@users.sf.net> | 2022-01-02 06:09:38 +0100 |
| commit | 7d37d296f942ac993d041b4576ed52265170c4a8 (patch) | |
| tree | bf36eca388b7fdc363ef21f4defa8ac9c449141d /lib/user.cpp | |
| parent | d516280a2b38ccb060e4f7502b873e19b1559ed1 (diff) | |
| download | libquotient-7d37d296f942ac993d041b4576ed52265170c4a8.tar.gz libquotient-7d37d296f942ac993d041b4576ed52265170c4a8.zip | |
Add ImplPtr and makeImpl
The original (more complex and comprehensive) solution belongs to
https://oliora.github.io/2015/12/29/pimpl-and-rule-of-zero.html - this
commit only provides a small wrapper for non-copyable Private class
implementations common throughout libQuotient. Unlike the original,
default initialisation is made explicit - you have to pass
ZeroImpl<Private>() instead (and I firmly believe it's a good thing:
normally pointers to Private should not remain nullptr). The reason
ZeroImpl<> is not a template variable is quite simple: unique_ptr is
non-copyable and so cannot be initialised from; while a template
function will initialise the value in-place thanks to copy elision.
Diffstat (limited to 'lib/user.cpp')
| -rw-r--r-- | lib/user.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/user.cpp b/lib/user.cpp index 7da71dba..0dbc444a 100644 --- a/lib/user.cpp +++ b/lib/user.cpp @@ -46,7 +46,7 @@ public: decltype(User::Private::otherAvatars) User::Private::otherAvatars {}; User::User(QString userId, Connection* connection) - : QObject(connection), d(new Private(move(userId))) + : QObject(connection), d(makeImpl<Private>(move(userId))) { setObjectName(id()); if (connection->userId() == id()) { @@ -61,8 +61,6 @@ Connection* User::connection() const return static_cast<Connection*>(parent()); } -User::~User() = default; - void User::load() { auto* profileJob = |