Make enum values logging more terse()

By default enum class values are logged along with the qualifier; this
may or may not be desirable in a given setting. For JoinState(s) and
Membership(Mask) operator<< was overloaded to implicitly suppress
qualification; however, this is both overly sweeping and uses Qt's
internal API for the backend.

Instead, a new QDebug manipulator, terse(), is introduced, that does
the same as those operator<< overloads but on a per-invocation basis.
This makes it slightly more verbose to log enums but makes the QDebug
reconfiguration explicit and doesn't require to produce new overloads
every time a new enum ends up in logs. And it's built entirely on
the published Qt API, reusing the QDebugManip framework that Quotient
already has.

Also: operator<<(QDebug, QDebugManip) has been moved out of
the namespace to fix lookup issues when there's no prior
`using namespace Quotient`.

1 files changed, 0 insertions, 6 deletions

diff --git a/lib/quotient_common.h b/lib/quotient_common.h
index 3d8ace67..969ebe90 100644
--- a/lib/quotient_common.h
+++ b/lib/quotient_common.h
@@ -118,9 +118,3 @@ constexpr inline auto RoomTypeStrings = make_array(
 } // namespace Quotient
 Q_DECLARE_OPERATORS_FOR_FLAGS(Quotient::MembershipMask)
 Q_DECLARE_OPERATORS_FOR_FLAGS(Quotient::JoinStates)
-
-class QDebug;
-QDebug operator<<(QDebug dbg, Quotient::Membership m);
-QDebug operator<<(QDebug dbg, Quotient::MembershipMask m);
-QDebug operator<<(QDebug dbg, Quotient::JoinState js);
-QDebug operator<<(QDebug dbg, Quotient::JoinStates js);