Cleanup across E2EE code

Notably:
- simplified unnecessarily verbose constructs;
- formally aligned (no re-numeration was necessary)
  QOlmMessage::Type with corresponding OLM_ constants;
- dropped QOlmSession::encryptMessageType() because it's very
  sensitive to the order of calling with QOlmSession::encrypt()
  (and encrypt() itself already calls it and returns the message
  type);
- simplify the return type of pickle() calls that can only fail due to
  an internal error;
- replace const QString& with QStringView or const QByteArray&
  where appropriate;
- use '\0' where it was meant to be instead of '0'.

1 files changed, 3 insertions, 3 deletions

diff --git a/lib/keyverificationsession.cpp b/lib/keyverificationsession.cpp
index 3f76eac1..0f24c743 100644
--- a/lib/keyverificationsession.cpp
+++ b/lib/keyverificationsession.cpp
@@ -71,9 +71,9 @@ void KeyVerificationSession::init(milliseconds timeout)
     QTimer::singleShot(timeout, this, [this] { cancelVerification(TIMEOUT); });
 
     m_sas = olm_sas(new std::byte[olm_sas_size()]);
-    auto randomSize = olm_create_sas_random_length(m_sas);
-    auto random = getRandom(randomSize);
-    olm_create_sas(m_sas, random.data(), randomSize);
+    const auto randomLength = olm_create_sas_random_length(m_sas);
+    auto random = getRandom(randomLength);
+    olm_create_sas(m_sas, random.data(), randomLength);
 }
 
 KeyVerificationSession::~KeyVerificationSession()