Refactor EventFactory and move it out of _impl::

Strictly speaking, EventFactory can be further instantiated if any
client application figures they need a whole new base class for events
and respectively a separate EventFactory specialisation for it.

Where this whole commit started though was a linkage error because I
did not plan to expose Quotient-specific logging categories for linkage
(effectively, usage) from the client code - meanwhile the inline code
of EventFactory uses qDebug(EVENTS), meaning I had to either add
QUOTIENT_API to EVENTS or hide those invocations. This in turn led
to trimming the EventFactory constructor back to trivial implementation
and dropping the guard variable that was supposed to trace duplicate
EventFactory<BaseEventT> objects for the same BaseEventT - with the
reasoning that such situation is not really dangerous (unlike
EventTypeRegistry double-initialisation fiasco, see #413), and at the
same time it can be easily detected in the logs by duplicated factory
method registration messages. And while I was at it, I replaced the
meaningless bool in the return type of EventFactory<>::addMethod with
the slightly more (but still barely) useful reference to the inserted
factory method. One can (in theory) use it now if they need to turn
some event JSON into an object of some specific event type or nullptr
if the event type in the JSON payload doesn't match - but at the same
rate (for now at least) one can call makeIfMatches<EventT>() directly.

With this commit, both Quotest and Quaternion build and link using
either Clang or GCC even under -fvisibility=hidden. However, running
quotest now reproduces #413, which is a matter of event typeId
infrastructure refactoring, coming in further commits.

1 files changed, 8 insertions, 0 deletions

diff --git a/lib/events/event.cpp b/lib/events/event.cpp
index 96be717c..715e7da2 100644
--- a/lib/events/event.cpp
+++ b/lib/events/event.cpp
@@ -27,6 +27,14 @@ QString EventTypeRegistry::getMatrixType(event_type_t typeId)
                                             : QString();
 }
 
+void _impl::EventFactoryBase::logAddingMethod(event_mtype_t matrixType,
+                                              size_t newSize)
+{
+    qDebug(EVENTS) << "Adding factory method for" << matrixType << "events;"
+                   << newSize << "methods will be in the" << name
+                   << "chain";
+}
+
 Event::Event(Type type, const QJsonObject& json) : _type(type), _json(json)
 {
     if (!json.contains(ContentKeyL)