diff options
| author | Nicolas Fella <nicolas.fella@gmx.de> | 2020-12-27 21:24:06 +0100 |
|---|---|---|
| committer | Nicolas Fella <nicolas.fella@gmx.de> | 2020-12-27 21:24:06 +0100 |
| commit | 9d854e778d8d6ef8e03e1ea74fe958675b24fd45 (patch) | |
| tree | 96879173cdc53b17f0a7994ac8ea9a70757503fc /lib/csapi/leaving.h | |
| parent | d5670a9dea90e111d805ae144c7295cd58b29d22 (diff) | |
| download | libquotient-9d854e778d8d6ef8e03e1ea74fe958675b24fd45.tar.gz libquotient-9d854e778d8d6ef8e03e1ea74fe958675b24fd45.zip | |
Fix use-after-free of QNetworkReply in BaseJob
Usually QNetworkAccessManager expects the user to delete the replies, but when the QNetworkAccessManager itself is deleted it deletes all pending replies (https://code.woboq.org/qt5/qtbase/src/network/access/qnetworkaccessmanager.cpp.html#529).
This can lead to use-after-free crashes when d->reply is accessed. By putting the reply into a QPointer the exiting if(d->reply) checks can work properly.
Diffstat (limited to 'lib/csapi/leaving.h')
0 files changed, 0 insertions, 0 deletions