diff options
| author | Nicolas Fella <nicolas.fella@gmx.de> | 2020-12-27 21:24:06 +0100 |
|---|---|---|
| committer | Kitsune Ral <Kitsune-Ral@users.sf.net> | 2020-12-27 22:25:44 +0100 |
| commit | f286ef4c5b3c71510d6ef15e8cc12cada84f3682 (patch) | |
| tree | 8ff187ab7d3ae3dfa8d653c499ed16338b4a073d /lib/csapi/definitions | |
| parent | d6c2622b0cdc33ad272542ab611c15de07202520 (diff) | |
| download | libquotient-f286ef4c5b3c71510d6ef15e8cc12cada84f3682.tar.gz libquotient-f286ef4c5b3c71510d6ef15e8cc12cada84f3682.zip | |
Fix use-after-free of QNetworkReply in BaseJob
Usually QNetworkAccessManager expects the user to delete the replies, but when the QNetworkAccessManager itself is deleted it deletes all pending replies (https://code.woboq.org/qt5/qtbase/src/network/access/qnetworkaccessmanager.cpp.html#529).
This can lead to use-after-free crashes when d->reply is accessed. By putting the reply into a QPointer the exiting if(d->reply) checks can work properly.
(cherry picked from commit 9d854e778d8d6ef8e03e1ea74fe958675b24fd45)
Diffstat (limited to 'lib/csapi/definitions')
0 files changed, 0 insertions, 0 deletions