BaseJob: more careful error handling; unify and extend error signals in Connection

(Note: this commit breaks back-compatibility.)

BaseJob::gotReply() had a bold assumption that whenever there's no reasonable JSON body in case of error, that meant IncorrectRequestError (which of course was incorrect). This led to syncs dying in Quaternion because it (correctly) considered IncorrectRequestError to be grave enough to not retry. Closes #206.
Also: don't dump the whole payload to logs, limit with initial 500 characters (closes #205)

1 files changed, 4 insertions, 3 deletions

diff --git a/lib/connection.h b/lib/connection.h
index 6dd0db1d..4ce1d127 100644
--- a/lib/connection.h
+++ b/lib/connection.h
@@ -351,11 +351,12 @@ namespace QMatrixClient
             void connected();
             void reconnected(); //< Unused; use connected() instead
             void loggedOut();
-            void loginError(QString error);
-            void networkError(int retriesTaken, int inMilliseconds);
+            void loginError(QString message, QByteArray details);
+            void networkError(QString message, QByteArray details,
+                              int retriesTaken, int nextRetryInMilliseconds);
 
             void syncDone();
-            void syncError(QString error);
+            void syncError(QString message, QByteArray details);
 
             void newUser(User* user);