diff options
| author | Kitsune Ral <Kitsune-Ral@users.sf.net> | 2016-07-26 16:49:16 +0900 |
|---|---|---|
| committer | Kitsune Ral <Kitsune-Ral@users.sf.net> | 2016-07-26 16:51:11 +0900 |
| commit | 3254963c1ea587921d2a434839aa703b9aaff6cc (patch) | |
| tree | a5b540e8112acdf25d05f0c4bf3110e4613b8a3c /jobs/roommessagesjob.h | |
| parent | 2eb18a735a5f75a77387a211f4311222d00c2d6c (diff) | |
| download | libquotient-3254963c1ea587921d2a434839aa703b9aaff6cc.tar.gz libquotient-3254963c1ea587921d2a434839aa703b9aaff6cc.zip | |
Split BaseJob::gotReply into checkReply and parseReply + internal tweaks to BaseJob
1. The externally (for derived classes) visible additions are checkReply() and parseReply() virtual methods, with gotReply becoming a mere dispatcher (and therefore a private method). Splitting gotReply() in that way allowed to remove boilerplate code from MediaThumbnailJob.
2. The internal tweak is using QScopedPointer<> to store pointers both to the Private object and to a QNetworkReply (with a special deleter that aborts the reply before destructing the object). This allows to remove desperate attempts to call reply->abort() wherever it's no more needed (and not aborting the in-flight replies seems to be a/the culprit of Quaternion after-exit hangs).
Diffstat (limited to 'jobs/roommessagesjob.h')
0 files changed, 0 insertions, 0 deletions