Code cleanup and tweaking (partially driven by clang-tidy)

Mainly it's about const-ification (in particular, passing const-refs instead of values) and deleting unneeded declarations/#includes. Since the changes alter the external interface, this is submitted as a PR for peer review.

One of unneeded declarations/definitions is a virtual destructor in BaseJob descendants. Since a job object should be deleted through QObject::deleteLater() anyway (and it's the only correct way of disposing of the object), all deletions will call the stack of destructors through virtual QObject::~QObject(). Therefore even BaseJob could get on with a non-virtual destructor but for the sake of clarity BaseJob::~BaseJob() is still declared virtual.

1 files changed, 3 insertions, 3 deletions

diff --git a/jobs/postmessagejob.h b/jobs/postmessagejob.h
index 14de52f0..f4ae809b 100644
--- a/jobs/postmessagejob.h
+++ b/jobs/postmessagejob.h
@@ -26,10 +26,10 @@ namespace QMatrixClient
     {
         public:
             /** Constructs a plain text message job */
-            PostMessageJob(ConnectionData* connection, const QString& roomId,
+            PostMessageJob(const ConnectionData* connection, const QString& roomId,
                            const QString& type, const QString& plainText);
             /** Constructs a rich text message job */
-            PostMessageJob(ConnectionData* connection, const QString& roomId,
+            PostMessageJob(const ConnectionData* connection, const QString& roomId,
                            const QString& type, const QString& plainText,
                            const QString& richText);
             virtual ~PostMessageJob();
@@ -43,4 +43,4 @@ namespace QMatrixClient
             class Private;
             Private* d;
     };
-}
+}  // namespace QMatrixClient