All jobs: Drop ConnectionData parameter from the constructor

Having to pass ConnectionData to each and every job class was nothing but boilerplate since the very beginning. Removing it required to prepend BaseJob::start() with ConnectionData-setting code, and to provide a way to alter the request configuration depending on the (late-coming) ConnectionData object. This is a new responsibility of BaseJob::start(); the previous BaseJob::start() contents have moved to BaseJob::sendRequest() (which is now invoked on retries, instead of start()).

1 files changed, 5 insertions, 5 deletions

diff --git a/jobs/passwordlogin.cpp b/jobs/passwordlogin.cpp
index 09108215..9af025e6 100644
--- a/jobs/passwordlogin.cpp
+++ b/jobs/passwordlogin.cpp
@@ -28,8 +28,8 @@ class PasswordLogin::Private
         QString returned_token;
 };
 
-PasswordLogin::PasswordLogin(const ConnectionData* connection, QString user, QString password)
-    : BaseJob(connection, HttpVerb::Post, "PasswordLogin"
+PasswordLogin::PasswordLogin(QString user, QString password)
+    : BaseJob(HttpVerb::Post, "PasswordLogin"
             , "_matrix/client/r0/login"
             , Query()
             , Data(
@@ -48,17 +48,17 @@ PasswordLogin::~PasswordLogin()
     delete d;
 }
 
-QString PasswordLogin::token()
+QString PasswordLogin::token() const
 {
     return d->returned_token;
 }
 
-QString PasswordLogin::id()
+QString PasswordLogin::id() const
 {
     return d->returned_id;
 }
 
-QString PasswordLogin::server()
+QString PasswordLogin::server() const
 {
     return d->returned_server;
 }