All jobs: Drop ConnectionData parameter from the constructor

Having to pass ConnectionData to each and every job class was nothing but boilerplate since the very beginning. Removing it required to prepend BaseJob::start() with ConnectionData-setting code, and to provide a way to alter the request configuration depending on the (late-coming) ConnectionData object. This is a new responsibility of BaseJob::start(); the previous BaseJob::start() contents have moved to BaseJob::sendRequest() (which is now invoked on retries, instead of start()).

1 files changed, 3 insertions, 3 deletions

diff --git a/jobs/checkauthmethods.cpp b/jobs/checkauthmethods.cpp
index 95b9a8f2..117def89 100644
--- a/jobs/checkauthmethods.cpp
+++ b/jobs/checkauthmethods.cpp
@@ -29,9 +29,9 @@ class CheckAuthMethods::Private
         QString session;
 };
 
-CheckAuthMethods::CheckAuthMethods(const ConnectionData* connection)
-    : BaseJob(connection, HttpVerb::Get, "CheckAuthMethods",
-              "_matrix/client/r0/login", Query(), Data(), false)
+CheckAuthMethods::CheckAuthMethods()
+    : BaseJob(HttpVerb::Get, "CheckAuthMethods",
+              QStringLiteral("_matrix/client/r0/login"), Query(), Data(), false)
     , d(new Private)
 {
 }