Code cleanup and tweaking (partially driven by clang-tidy)

Mainly it's about const-ification (in particular, passing const-refs instead of values) and deleting unneeded declarations/#includes. Since the changes alter the external interface, this is submitted as a PR for peer review.

One of unneeded declarations/definitions is a virtual destructor in BaseJob descendants. Since a job object should be deleted through QObject::deleteLater() anyway (and it's the only correct way of disposing of the object), all deletions will call the stack of destructors through virtual QObject::~QObject(). Therefore even BaseJob could get on with a non-virtual destructor but for the sake of clarity BaseJob::~BaseJob() is still declared virtual.

1 files changed, 2 insertions, 2 deletions

diff --git a/events/roomnameevent.cpp b/events/roomnameevent.cpp
index c5bcf011..c94cb2c3 100644
--- a/events/roomnameevent.cpp
+++ b/events/roomnameevent.cpp
@@ -22,8 +22,8 @@ using namespace QMatrixClient;
 

 class RoomNameEvent::Private

 {

-public:

-    QString name;

+    public:

+        QString name;

 };

 

 RoomNameEvent::RoomNameEvent() :