diff options
| author | Carl Schwan <carl@carlschwan.eu> | 2021-04-19 16:07:57 +0200 |
|---|---|---|
| committer | Tobias Fella <fella@posteo.de> | 2021-12-01 21:34:52 +0100 |
| commit | ea617d31cf3f72f76fd49c0a20f445a78678fe5f (patch) | |
| tree | a99a186670eb3b50588411fe6d4eb9ddad2dfcb4 /autotests | |
| parent | bc4ef60c29709a6f782f6e75e1f040f250fb8bd7 (diff) | |
| download | libquotient-ea617d31cf3f72f76fd49c0a20f445a78678fe5f.tar.gz libquotient-ea617d31cf3f72f76fd49c0a20f445a78678fe5f.zip | |
Apply suggestions from code review
Co-authored-by: Tobias Fella <9750016+TobiasFella@users.noreply.github.com>
Diffstat (limited to 'autotests')
| -rw-r--r-- | autotests/testgroupsession.cpp | 1 | ||||
| -rw-r--r-- | autotests/testgroupsession.h | 2 | ||||
| -rw-r--r-- | autotests/testolmaccount.h | 3 | ||||
| -rw-r--r-- | autotests/testolmsession.cpp | 2 | ||||
| -rw-r--r-- | autotests/testolmsession.h | 2 | ||||
| -rw-r--r-- | autotests/testolmutility.h | 2 |
6 files changed, 5 insertions, 7 deletions
diff --git a/autotests/testgroupsession.cpp b/autotests/testgroupsession.cpp index 858f29d8..ea1bb4a9 100644 --- a/autotests/testgroupsession.cpp +++ b/autotests/testgroupsession.cpp @@ -41,7 +41,6 @@ void TestOlmSession::groupSessionCryptoValid() const auto plainText = QStringLiteral("Hello world!"); const auto ciphertext = std::get<QByteArray>(ogs->encrypt(plainText)); - qDebug() << ciphertext; // ciphertext valid base64? QVERIFY(QByteArray::fromBase64Encoding(ciphertext).decodingStatus == QByteArray::Base64DecodingStatus::Ok); diff --git a/autotests/testgroupsession.h b/autotests/testgroupsession.h index 27f34bec..7743295f 100644 --- a/autotests/testgroupsession.h +++ b/autotests/testgroupsession.h @@ -2,7 +2,7 @@ // // SPDX-License-Identifier: LGPL-2.1-or-later -#include <QtTest/QtTest> +#include <QTest> class TestOlmSession : public QObject { diff --git a/autotests/testolmaccount.h b/autotests/testolmaccount.h index 97fbca18..8901f095 100644 --- a/autotests/testolmaccount.h +++ b/autotests/testolmaccount.h @@ -2,7 +2,7 @@ // // SPDX-License-Identifier: LGPL-2.1-or-later -#include <QtTest/QtTest> +#include <QTest> #include <QString> namespace Quotient { @@ -13,7 +13,6 @@ class TestOlmAccount : public QObject { Q_OBJECT - private Q_SLOTS: void pickleUnpickledTest(); void identityKeysValid(); diff --git a/autotests/testolmsession.cpp b/autotests/testolmsession.cpp index 72c54174..0803cc6d 100644 --- a/autotests/testolmsession.cpp +++ b/autotests/testolmsession.cpp @@ -26,7 +26,7 @@ std::pair<std::unique_ptr<QOlmSession>, std::unique_ptr<QOlmSession>> createSess const auto preKey = outbound->encrypt(""); // Payload does not matter for PreKey if (preKey.type() != QOlmMessage::PreKey) { - throw "Wrong first message type received, can't create session"; + QFAIL("Wrong first message type received, can't create session"); } auto inbound = std::get<std::unique_ptr<QOlmSession>>(accountB.createInboundSession(preKey)); return std::make_pair<std::unique_ptr<QOlmSession>, std::unique_ptr<QOlmSession>>(std::move(inbound), std::move(outbound)); diff --git a/autotests/testolmsession.h b/autotests/testolmsession.h index 9a5798fa..bd670c9b 100644 --- a/autotests/testolmsession.h +++ b/autotests/testolmsession.h @@ -2,7 +2,7 @@ // // SPDX-License-Identifier: LGPL-2.1-or-later -#include <QtTest/QtTest> +#include <QTest> class TestOlmSession : public QObject { diff --git a/autotests/testolmutility.h b/autotests/testolmutility.h index b30249c8..f2a3ca45 100644 --- a/autotests/testolmutility.h +++ b/autotests/testolmutility.h @@ -2,7 +2,7 @@ // // SPDX-License-Identifier: LGPL-2.1-or-later -#include <QtTest/QtTest> +#include <QTest> class TestOlmUtility : public QObject { |