diff options
| author | Alexey Rusakov <Kitsune-Ral@users.sf.net> | 2022-09-25 21:37:49 +0200 |
|---|---|---|
| committer | Alexey Rusakov <Kitsune-Ral@users.sf.net> | 2022-09-25 21:37:49 +0200 |
| commit | 5904a61c59f0eef00aef07ef998658fd791ff139 (patch) | |
| tree | 58d3a367918d1516efeba2e4bff632f3b5f4e4a5 /autotests | |
| parent | 62f9e5b7d1227a85f80ae49abcb555e4fe4c52f0 (diff) | |
| download | libquotient-5904a61c59f0eef00aef07ef998658fd791ff139.tar.gz libquotient-5904a61c59f0eef00aef07ef998658fd791ff139.zip | |
QOlmUtility::ed25519Verify: just return bool
It's too easy to incorrectly test the previous return type.
Diffstat (limited to 'autotests')
| -rw-r--r-- | autotests/testolmaccount.cpp | 3 | ||||
| -rw-r--r-- | autotests/testolmutility.cpp | 6 |
2 files changed, 3 insertions, 6 deletions
diff --git a/autotests/testolmaccount.cpp b/autotests/testolmaccount.cpp index 280705d0..a41af268 100644 --- a/autotests/testolmaccount.cpp +++ b/autotests/testolmaccount.cpp @@ -58,8 +58,7 @@ void TestOlmAccount::signatureValid() QOlmUtility utility; const auto identityKeys = olmAccount.identityKeys(); const auto ed25519Key = identityKeys.ed25519; - const auto verify = utility.ed25519Verify(ed25519Key, message, signature); - QVERIFY(verify.value_or(false)); + QVERIFY(utility.ed25519Verify(ed25519Key, message, signature)); } void TestOlmAccount::oneTimeKeysValid() diff --git a/autotests/testolmutility.cpp b/autotests/testolmutility.cpp index 5b67c805..1d461a94 100644 --- a/autotests/testolmutility.cpp +++ b/autotests/testolmutility.cpp @@ -81,10 +81,8 @@ void TestOlmUtility::verifySignedOneTimeKey() delete[](reinterpret_cast<uint8_t *>(utility)); QOlmUtility utility2; - auto res2 = - utility2 - .ed25519Verify(aliceOlm.identityKeys().ed25519, msg, signatureBuf1) - .value_or(false); + auto res2 = utility2.ed25519Verify(aliceOlm.identityKeys().ed25519, msg, + signatureBuf1); //QCOMPARE(std::string(olm_utility_last_error(utility)), "SUCCESS"); QVERIFY(res2); |