diff options
| author | Kitsune Ral <Kitsune-Ral@users.sf.net> | 2018-02-04 23:12:42 +0900 |
|---|---|---|
| committer | Kitsune Ral <Kitsune-Ral@users.sf.net> | 2018-02-07 15:12:46 +0900 |
| commit | 6a9b1876bf8ebeca398c9c57ef90e01c25a7ada6 (patch) | |
| tree | 6204ed845a188709ad276658eb7187c07295ad82 | |
| parent | 898f0c73b4d76c091e48c5e767b94d6ad18f582f (diff) | |
| download | libquotient-6a9b1876bf8ebeca398c9c57ef90e01c25a7ada6.tar.gz libquotient-6a9b1876bf8ebeca398c9c57ef90e01c25a7ada6.zip | |
MediaThumbnailJob::parseReply: Do not ignore underlying errors
| -rw-r--r-- | jobs/mediathumbnailjob.cpp | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/jobs/mediathumbnailjob.cpp b/jobs/mediathumbnailjob.cpp index 261978ec..dda1cdb4 100644 --- a/jobs/mediathumbnailjob.cpp +++ b/jobs/mediathumbnailjob.cpp @@ -52,10 +52,12 @@ QImage MediaThumbnailJob::scaledThumbnail(QSize toSize) const BaseJob::Status MediaThumbnailJob::parseReply(QNetworkReply* reply) { - GetContentThumbnailJob::parseReply(reply); - if( !_thumbnail.loadFromData(content()->readAll()) ) - { - qCDebug(JOBS) << "MediaThumbnailJob: could not read image data"; - } - return Success; + auto result = GetContentThumbnailJob::parseReply(reply); + if (!result.good()) + return result; + + if( _thumbnail.loadFromData(content()->readAll()) ) + return Success; + + return { IncorrectResponseError, "Could not read image data" }; } |