diff options
| author | Kitsune Ral <Kitsune-Ral@users.sf.net> | 2017-12-30 17:50:07 +0900 |
|---|---|---|
| committer | Kitsune Ral <Kitsune-Ral@users.sf.net> | 2017-12-30 17:50:07 +0900 |
| commit | 2c440249052b0d518fccd953a7dc657f9eed7ab7 (patch) | |
| tree | 1bb8cb0cccca20e46f66e3312433726fbe7f4f00 | |
| parent | 4377a868f0d69ca92afca13b0087aee2d97bd7ac (diff) | |
| download | libquotient-2c440249052b0d518fccd953a7dc657f9eed7ab7.tar.gz libquotient-2c440249052b0d518fccd953a7dc657f9eed7ab7.zip | |
BaseJob: do not suppress SSL errors
It is the application's responsibility to properly display the error and get confirmation from the user about it.
| -rw-r--r-- | jobs/basejob.cpp | 9 | ||||
| -rw-r--r-- | jobs/basejob.h | 1 |
2 files changed, 0 insertions, 10 deletions
diff --git a/jobs/basejob.cpp b/jobs/basejob.cpp index 3ea13c83..8d116c26 100644 --- a/jobs/basejob.cpp +++ b/jobs/basejob.cpp @@ -191,7 +191,6 @@ void BaseJob::sendRequest() if (!d->requestQuery.isEmpty()) qCDebug(d->logCat) << " query:" << d->requestQuery.toString(); d->sendRequest(); - connect( d->reply.data(), &QNetworkReply::sslErrors, this, &BaseJob::sslErrors ); connect( d->reply.data(), &QNetworkReply::finished, this, &BaseJob::gotReply ); if (d->reply->isRunning()) { @@ -371,14 +370,6 @@ void BaseJob::timeout() finishJob(); } -void BaseJob::sslErrors(const QList<QSslError>& errors) -{ - foreach (const QSslError &error, errors) { - qCWarning(d->logCat) << "SSL ERROR" << error.errorString(); - } - d->reply->ignoreSslErrors(); // TODO: insecure! should prompt user first -} - void BaseJob::setLoggingCategory(LoggingCategory lcf) { d->logCat = lcf; diff --git a/jobs/basejob.h b/jobs/basejob.h index 0d669b78..e3a379fa 100644 --- a/jobs/basejob.h +++ b/jobs/basejob.h @@ -267,7 +267,6 @@ namespace QMatrixClient virtual ~BaseJob(); protected slots: void timeout(); - void sslErrors(const QList<QSslError>& errors); private slots: void sendRequest(); |