diff options
| author | Alexey Rusakov <Kitsune-Ral@users.sf.net> | 2022-01-05 20:13:44 +0100 |
|---|---|---|
| committer | Alexey Rusakov <Kitsune-Ral@users.sf.net> | 2022-01-06 08:22:07 +0100 |
| commit | bc4a0f5d408d901f3c8f4dfeec0574ded04845bf (patch) | |
| tree | beba812c100d4805cf21b2264ca99ae144ce77fb /.gitmodules | |
| parent | 703e5e8c1b48bea7bd82906967cb7651f7e96751 (diff) | |
| download | libquotient-bc4a0f5d408d901f3c8f4dfeec0574ded04845bf.tar.gz libquotient-bc4a0f5d408d901f3c8f4dfeec0574ded04845bf.zip | |
Brush up SsoSession; document Connection::prepareForSso
Although parented to Connection, SsoSession was pretty leaky in that
unsuccessful login attempts didn't delete the object and in some errors
didn't even close the local HTTP socket (though new connections would no
more be accepted). Also, without the documentation it wasn't clear who
owns the object returned by Connection::prepareForSso(). Now it is.
Unfortunately, it's not easy to cover SsoSession with tests. Basically,
it takes a homeserver and a mock "SSO agent" that would check
the SSO URL for validity and then both send the login authorisation
to the homeserver as well as ping the callback given by SsoSession.
Maybe for another time.
Diffstat (limited to '.gitmodules')
0 files changed, 0 insertions, 0 deletions