logger fixes and better tests

1 files changed, 59 insertions, 0 deletions

diff --git a/logger/logger_test.go b/logger/logger_test.go
index ce708bb..4d07d8c 100644
--- a/logger/logger_test.go
+++ b/logger/logger_test.go
@@ -3,7 +3,9 @@ package logger
 import (
 	"bufio"
 	"bytes"
+	"log"
 	"os"
+	"path/filepath"
 	"reflect"
 	"strings"
 	"testing"
@@ -85,3 +87,60 @@ func TestInit(t *testing.T) {
 		}
 	}
 }
+
+func TestLevel(t *testing.T) {
+	initialize()
+	var buf bytes.Buffer
+	Init(1)
+	SetOutput(&buf)
+
+	Infof("info %d", sInfo)
+	Warningf("warning %d", sWarning)
+	Errorf("error %d", sError)
+	s := buf.String()
+	if strings.Contains(s, "info") {
+		t.Errorf("log output %q should not contain: info", s)
+	}
+	if strings.Contains(s, "warning") {
+		t.Errorf("log output %q should not contain: warning", s)
+	}
+	if !strings.Contains(s, "error") {
+		t.Errorf("log output %q should contain: error", s)
+	}
+}
+
+func TestFlags(t *testing.T) {
+	initialize()
+	l := Init(3)
+	SetFlags(log.Llongfile)
+	var buf bytes.Buffer
+	SetOutput(&buf)
+	l.Infof("info %d", sInfo)
+	s := buf.String()
+	if !strings.Contains(s, "info 0") {
+		t.Errorf("log output %q should contain: info 0", s)
+	}
+	path := filepath.Join("logger", "logger_test.go")
+	if !strings.Contains(s, path) {
+		t.Errorf("log output %q should contain: %s", s, path)
+	}
+
+	// bonus for coverage
+	l.Warning("warning")
+	l.Warningf("warning %d", sWarning)
+	l.Error("error")
+	l.Errorf("error %d", sError)
+	s = buf.String()
+	if !strings.Contains(s, "warning") {
+		t.Errorf("log output %q should contain: warning", s)
+	}
+	if !strings.Contains(s, "warning 1") {
+		t.Errorf("log output %q should contain: warning 1", s)
+	}
+	if !strings.Contains(s, "error") {
+		t.Errorf("log output %q should contain: error", s)
+	}
+	if !strings.Contains(s, "error 2") {
+		t.Errorf("log output %q should contain: error 2", s)
+	}
+}