aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorn-peugnet <n.peugnet@free.fr>2020-04-28 18:27:38 +0200
committern-peugnet <n.peugnet@free.fr>2020-04-28 18:27:38 +0200
commit30b516bfcf56249c6954bd1aaf4e3c52b18f57fe (patch)
treec2e44ee8c1e60135b771286df0f7dc9610100b23
parent3183ce9dd42211b7279c7ce545c414452f5a9ef0 (diff)
downloadwcms-30b516bfcf56249c6954bd1aaf4e3c52b18f57fe.tar.gz
wcms-30b516bfcf56249c6954bd1aaf4e3c52b18f57fe.zip
fix: error codes on error pages
- 404 on page not exist - 500 on unknown internal error Fixes #90
-rw-r--r--README.md2
-rw-r--r--app/class/Controllerpage.php1
-rw-r--r--index.php1
3 files changed, 3 insertions, 1 deletions
diff --git a/README.md b/README.md
index 492b6c9..0bb744f 100644
--- a/README.md
+++ b/README.md
@@ -179,7 +179,7 @@ Then, to make the release, run the following command:
To only build the release zip, simply run `make dist`. This will create a zip file in `dist/` of the current version.
[github]: https://github.com/vincent-peugnet/wcms/workflows/checks/badge.svg
-[action]: https://github.com/vincent-peugnet/wcms/actions
+[action]: https://github.com/vincent-peugnet/wcms/actions?query=branch%3Amaster+workflow%3Achecks
[codestyle]: https://img.shields.io/badge/code%20style-PSR12-brightgreen
[phpstan]: https://img.shields.io/badge/phpstan-level%205-green
[coverage]: https://coveralls.io/repos/github/vincent-peugnet/wcms/badge.svg?branch=master
diff --git a/app/class/Controllerpage.php b/app/class/Controllerpage.php
index ad6bf82..b5679a9 100644
--- a/app/class/Controllerpage.php
+++ b/app/class/Controllerpage.php
@@ -158,6 +158,7 @@ class Controllerpage extends Controller
echo 'Please render this page';
}
} else {
+ http_response_code(404);
$this->showtemplate(
'alert',
['page' => $this->page, 'pageexist' => $pageexist, 'canedit' => $this->canedit()]
diff --git a/index.php b/index.php
index 41a2184..154d947 100644
--- a/index.php
+++ b/index.php
@@ -38,5 +38,6 @@ try {
Sentry\captureException($e);
}
Logger::errorex($e, true);
+ http_response_code(500);
echo '<h1>⚠ Woops ! There is a little problem : </h1>', $e->getMessage(), "\n";
}