From d66de69ba57f00079ab8d5e4b9a1d1f73093e76a Mon Sep 17 00:00:00 2001 From: n-peugnet Date: Tue, 28 Apr 2020 19:08:49 +0200 Subject: tests: phpstan adjustments + 3 phpstan fixes - force exclude templates and vendor directories @vincent-peugnet: this should stop the phpstan-vscode extension to report errors in templates. - fix errors that were only reported on github because of php 7.3: - Missing @throws JsonException annotation - Regex pattern is invalid: Compilation failed: invalid range in character class at offset 16 in pattern: %(src|href)="([\w-_]+(\/([\w-_])+)*\.[a-z0-9]{1,5})"% the regex expected a range beacause the `-` char was placed in between two others. + `\w` includes `_` - plus one last easy error: PHPDoc tag @param references unknown parameter: $authorcompare --- app/class/Flywheel/Formatter/JSON.php | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'app/class/Flywheel') diff --git a/app/class/Flywheel/Formatter/JSON.php b/app/class/Flywheel/Formatter/JSON.php index 108c756..8ed8a66 100644 --- a/app/class/Flywheel/Formatter/JSON.php +++ b/app/class/Flywheel/Formatter/JSON.php @@ -2,12 +2,19 @@ namespace Wcms\Flywheel\Formatter; +use JsonException; + class JSON implements \JamesMoss\Flywheel\Formatter\FormatInterface { public function getFileExtension() { return 'json'; } + + /** + * @throws JsonException if json_encode fails in PHP7.3 + * @phpstan-ignore-next-line + */ public function encode(array $data) { $options = defined('JSON_PRETTY_PRINT') ? JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE : null; -- cgit v1.2.3