From 1f8fdcabeaa3151037954d556537f8fba4488b2c Mon Sep 17 00:00:00 2001 From: n-peugnet Date: Thu, 30 Apr 2020 21:53:01 +0200 Subject: fix: Can't find variable: InputEvent on Safari Use the old Event instead of the experimental InputEvent. Fixes Sentry WCMS-N --- src/edit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/edit.js b/src/edit.js index 86f24c2..b1613f3 100644 --- a/src/edit.js +++ b/src/edit.js @@ -93,7 +93,7 @@ let editors = []; let unsavedChanges = false; /** @type {InputEvent} */ -const inputEvent = new InputEvent('input'); +const inputEvent = new Event('input'); window.addEventListener('load', () => { form = document.getElementById('update'); -- cgit v1.2.3 From 4cc8d4b92ae6d3b49372ae7f26b8f8468a8c16b5 Mon Sep 17 00:00:00 2001 From: n-peugnet Date: Thu, 30 Apr 2020 22:41:49 +0200 Subject: tests: use codecov instead of coveralls coveralls didn't properly aggregated the coverage results from all the builds. --- .github/workflows/php.yml | 12 ++++++------ README.md | 8 ++++---- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml index 039daca..6172685 100644 --- a/.github/workflows/php.yml +++ b/.github/workflows/php.yml @@ -45,12 +45,12 @@ jobs: make test echo "::remove-matcher owner=phpunit::" - - name: Coveralls publish - env: - COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - composer require --quiet --no-interaction cedx/coveralls - vendor/bin/coveralls build/phpunit/cov.xml + - name: Codecov upload + uses: codecov/codecov-action@v1 + with: + file: ./build/phpunit/cov.xml + flags: php + name: php-${{ matrix.php-versions }} lint: name: lint diff --git a/README.md b/README.md index 58de3b7..4d0786e 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # W-CMS -[![checks][github]][action] ![style][codestyle] ![phpstan][phpstan] [![coverage][coverage]][coveralls] +[![checks][github]][action] ![style][codestyle] ![phpstan][phpstan] [![coverage][coverage]][codecov] W is a lightweight CMS tool, meant to help you design a website using a unique approach. It's targeting artists, or experimental projects. @@ -183,9 +183,9 @@ Then, to make the release, run the following command: To only build the release zip, simply run `make dist`. This will create a zip file in `dist/` of the current version. -[github]: https://github.com/vincent-peugnet/wcms/workflows/checks/badge.svg +[github]: https://img.shields.io/github/workflow/status/vincent-peugnet/wcms/checks/master?label=checks [action]: https://github.com/vincent-peugnet/wcms/actions?query=branch%3Amaster+workflow%3Achecks [codestyle]: https://img.shields.io/badge/code%20style-PSR12-brightgreen [phpstan]: https://img.shields.io/badge/phpstan-level%205-green -[coverage]: https://coveralls.io/repos/github/vincent-peugnet/wcms/badge.svg?branch=master -[coveralls]: https://coveralls.io/github/vincent-peugnet/wcms?branch=master \ No newline at end of file +[coverage]: https://img.shields.io/codecov/c/gh/vincent-peugnet/wcms +[codecov]: https://codecov.io/gh/vincent-peugnet/wcms -- cgit v1.2.3 From 6ab276cf38e20266862e97a7beffec562d35bef0 Mon Sep 17 00:00:00 2001 From: n-peugnet Date: Fri, 8 May 2020 12:49:08 +0200 Subject: fix: closing tag bug - escape the value in php templates - clean edittab template by the way @vincent-peugnet, you should never use echo in a template Fixes #112 --- app/view/templates/edittabs.php | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/app/view/templates/edittabs.php b/app/view/templates/edittabs.php index c890677..cc7739f 100644 --- a/app/view/templates/edittabs.php +++ b/app/view/templates/edittabs.php @@ -1,25 +1,24 @@
- $value) { - echo '
'; - ?> + $value) { ?> +
> - - echo '
'; - if ($key == $opentab) { - echo ''; - } else { - echo ''; - } - echo '
'; - echo '
'; -} -?> + +
+
+ \ No newline at end of file -- cgit v1.2.3