From 78c1a2db7c42b7d2cd5a036a5ef19bb95c679b86 Mon Sep 17 00:00:00 2001
From: Alexey Rusakov <Kitsune-Ral@users.sf.net>
Date: Fri, 15 Jul 2022 14:31:01 +0200
Subject: Connection::user(): validate after lookup, not before

If userMap only holds valid ids, there's no reason to spend time
validating the sought id: if it's invalid, it won't be found. And
lookups over a hash map are cheap.
---
 lib/connection.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

(limited to 'lib')

diff --git a/lib/connection.cpp b/lib/connection.cpp
index 701f78c2..81151135 100644
--- a/lib/connection.cpp
+++ b/lib/connection.cpp
@@ -1456,12 +1456,14 @@ User* Connection::user(const QString& uId)
 {
     if (uId.isEmpty())
         return nullptr;
+    if (const auto v = d->userMap.value(uId, nullptr))
+        return v;
+    // Before creating a user object, check that the user id is well-formed
+    // (it's faster to just do a lookup above before validation)
     if (!uId.startsWith('@') || serverPart(uId).isEmpty()) {
         qCCritical(MAIN) << "Malformed userId:" << uId;
         return nullptr;
     }
-    if (d->userMap.contains(uId))
-        return d->userMap.value(uId);
     auto* user = userFactory()(this, uId);
     d->userMap.insert(uId, user);
     emit newUser(user);
-- 
cgit v1.2.3