From 77b69eb370e1cdbc33e44121f4f8483e19cad7d8 Mon Sep 17 00:00:00 2001
From: Alexey Rusakov <Kitsune-Ral@users.sf.net>
Date: Sun, 12 Sep 2021 04:37:08 +0200
Subject: MxcReply: make sure to create a Private object

---
 lib/mxcreply.cpp | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

(limited to 'lib/mxcreply.cpp')

diff --git a/lib/mxcreply.cpp b/lib/mxcreply.cpp
index daa4af9a..0b6643fc 100644
--- a/lib/mxcreply.cpp
+++ b/lib/mxcreply.cpp
@@ -10,13 +10,16 @@ using namespace Quotient;
 class MxcReply::Private
 {
 public:
-    QNetworkReply *m_reply = nullptr;
+    explicit Private(QNetworkReply* r = nullptr)
+        : m_reply(r)
+    {}
+    QNetworkReply* m_reply;
 };
 
 MxcReply::MxcReply(QNetworkReply* reply)
+    : d(std::make_unique<Private>(reply))
 {
     reply->setParent(this);
-    d->m_reply = reply;
     connect(d->m_reply, &QNetworkReply::finished, this, [this]() {
         setError(d->m_reply->error(), d->m_reply->errorString());
         setOpenMode(ReadOnly);
@@ -25,10 +28,9 @@ MxcReply::MxcReply(QNetworkReply* reply)
 }
 
 MxcReply::MxcReply(QNetworkReply* reply, Room* room, const QString &eventId)
-    : d(std::make_unique<Private>())
+    : d(std::make_unique<Private>(reply))
 {
     reply->setParent(this);
-    d->m_reply = reply;
     connect(d->m_reply, &QNetworkReply::finished, this, [this, room, eventId]() {
         setError(d->m_reply->error(), d->m_reply->errorString());
         setOpenMode(ReadOnly);
-- 
cgit v1.2.3