From 4943cbea505aacdd33bf93c3365588ba73785d4d Mon Sep 17 00:00:00 2001
From: Kitsune Ral <Kitsune-Ral@users.sf.net>
Date: Thu, 13 Oct 2016 09:07:15 +0900
Subject: BaseJob: Use saved parameters instead of overriding apiPath(),
 query() and data() in each job class

---
 jobs/roommessagesjob.cpp | 36 ++++++++----------------------------
 1 file changed, 8 insertions(+), 28 deletions(-)

(limited to 'jobs/roommessagesjob.cpp')

diff --git a/jobs/roommessagesjob.cpp b/jobs/roommessagesjob.cpp
index f880713d..d67ffc2a 100644
--- a/jobs/roommessagesjob.cpp
+++ b/jobs/roommessagesjob.cpp
@@ -29,23 +29,20 @@ class RoomMessagesJob::Private
     public:
         Private() {}
 
-        Room* room;
-        QString from;
-        FetchDirectory dir;
-        int limit;
-
         Events events;
         QString end;
 };
 
 RoomMessagesJob::RoomMessagesJob(ConnectionData* data, Room* room, QString from, FetchDirectory dir, int limit)
-    : BaseJob(data, JobHttpType::GetJob, "RoomMessagesJob")
+    : BaseJob(data, JobHttpType::GetJob, "RoomMessagesJob",
+              QString("/_matrix/client/r0/rooms/%1/messages").arg(room->id()),
+              Query(
+                { { "from", from }
+                , { "dir", dir == FetchDirectory::Backwards ? "b" : "f" }
+                , { "limit", QString::number(limit) }
+                }))
+    , d(new Private)
 {
-    d = new Private();
-    d->room = room;
-    d->from = from;
-    d->dir = dir;
-    d->limit = limit;
 }
 
 RoomMessagesJob::~RoomMessagesJob()
@@ -63,23 +60,6 @@ QString RoomMessagesJob::end()
     return d->end;
 }
 
-QString RoomMessagesJob::apiPath() const
-{
-    return QString("/_matrix/client/r0/rooms/%1/messages").arg(d->room->id());
-}
-
-QUrlQuery RoomMessagesJob::query() const
-{
-    QUrlQuery query;
-    query.addQueryItem("from", d->from);
-    if( d->dir == FetchDirectory::Backwards )
-        query.addQueryItem("dir", "b");
-    else
-        query.addQueryItem("dir", "f");
-    query.addQueryItem("limit", QString::number(d->limit));
-    return query;
-}
-
 BaseJob::Status RoomMessagesJob::parseJson(const QJsonDocument& data)
 {
     QJsonObject obj = data.object();
-- 
cgit v1.2.3