From c8ae34af0c4b28ef5aabf60b97661241860bc200 Mon Sep 17 00:00:00 2001
From: Kitsune Ral <Kitsune-Ral@users.sf.net>
Date: Mon, 21 Oct 2019 09:41:46 +0900
Subject: ConnectionData: fix read-after-free in clearing the job queue

---
 lib/connectiondata.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/connectiondata.cpp b/lib/connectiondata.cpp
index a3807fc4..cbc36420 100644
--- a/lib/connectiondata.cpp
+++ b/lib/connectiondata.cpp
@@ -67,7 +67,6 @@ ConnectionData::ConnectionData(QUrl baseUrl)
         for (auto& q : d->jobs)
             while (!q.empty()) {
                 auto& job = q.front();
-                q.pop();
                 if (!job || job->error() == BaseJob::Abandoned)
                     continue;
                 if (job->error() != BaseJob::Pending) {
@@ -79,6 +78,7 @@ ConnectionData::ConnectionData(QUrl baseUrl)
                 }
                 job->sendRequest();
                 d->rateLimiter.start();
+                q.pop();
                 return;
             }
         qCDebug(MAIN) << d->id() << "job queues are empty";
-- 
cgit v1.2.3