From 703e5e8c1b48bea7bd82906967cb7651f7e96751 Mon Sep 17 00:00:00 2001
From: Alexey Rusakov <Kitsune-Ral@users.sf.net>
Date: Wed, 5 Jan 2022 15:53:21 +0100
Subject: Cleanup Room::pinnedEvents()

Use 'auto'; range-for instead of an iterator loop.
---
 lib/room.cpp | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/lib/room.cpp b/lib/room.cpp
index edf5dcd9..55efb5b9 100644
--- a/lib/room.cpp
+++ b/lib/room.cpp
@@ -562,16 +562,14 @@ QStringList Room::pinnedEventIds() const {
     return d->getCurrentState<RoomPinnedEvent>()->pinnedEvents();
 }
 
-QVector< const Quotient::RoomEvent* > Quotient::Room::pinnedEvents() const
+QVector<const Quotient::RoomEvent*> Quotient::Room::pinnedEvents() const
 {
-    QStringList events = d->getCurrentState<RoomPinnedEvent>()->pinnedEvents();
+    const auto& pinnedIds = d->getCurrentState<RoomPinnedEvent>()->pinnedEvents();
     QVector<const RoomEvent*> pinnedEvents;
-    QStringList::iterator i;
-    for (i = events.begin(); i != events.end(); ++i) {
-        auto timelineItem = findInTimeline(*i);
-        if (timelineItem != historyEdge())
-            pinnedEvents.append(timelineItem->event());
-    }
+    for (auto&& evtId: pinnedIds)
+        if (const auto& it = findInTimeline(evtId); it != historyEdge())
+            pinnedEvents.append(it->event());
+
     return pinnedEvents;
 }
 
-- 
cgit v1.2.3