From 5d94e0fa2a3cd1e43b99b0c309bc9e84c6850378 Mon Sep 17 00:00:00 2001 From: Roland Pallai Date: Sat, 17 Aug 2019 19:36:38 +0200 Subject: Update the cache for sure if unread counters were changed In Quaternion, I was able to reproduce a process where `d->notificationCount` and `d->highlightCount` were changed in `Room::updateData()` meanwhile `roomChanges` indicated `NoChange` thus the cache became permanently inconsistent with running state. Without deep understanding of `roomChanges` logic, I've applied this straightforward change which made this phenomenon unreproducible. --- lib/room.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/room.cpp b/lib/room.cpp index bee9e9cb..031f9467 100644 --- a/lib/room.cpp +++ b/lib/room.cpp @@ -1387,15 +1387,18 @@ void Room::updateData(SyncRoomData&& data, bool fromCache) if (data.unreadCount != -2 && data.unreadCount != d->unreadMessages) { qCDebug(MAIN) << "Setting unread_count to" << data.unreadCount; d->unreadMessages = data.unreadCount; + roomChanges |= Change::UnreadNotifsChange; emit unreadMessagesChanged(this); } if (data.highlightCount != d->highlightCount) { d->highlightCount = data.highlightCount; + roomChanges |= Change::UnreadNotifsChange; emit highlightCountChanged(); } if (data.notificationCount != d->notificationCount) { d->notificationCount = data.notificationCount; + roomChanges |= Change::UnreadNotifsChange; emit notificationCountChanged(); } if (roomChanges != Change::NoChange) { -- cgit v1.2.3