From 2dee2bf4f0b2bd6615866644b2df9460da6babbb Mon Sep 17 00:00:00 2001 From: Alexey Rusakov Date: Sat, 1 Jan 2022 20:46:12 +0100 Subject: Only test dynamic linking on Linux On Windows and macOS, the assumed practice is to package things up in a monolithic distribution package. On Linux, fine-grained library packages are installed. After adding CMAKE_INSTALL_RPATH_USE_LINK_PATH dynamic linkage is testable on macOS but that's not the "proper" way to install things on the platform, anyway. It also probably works on Windows but I couldn't get a workable setup for quotest after a few attempts. Perhaps it's a matter of running windeployqt instead of trying to figure out and add to PATH all the locations needed; or maybe not; I don't have the motivation to explore this further. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d4af9b30..ef6ea3d2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -108,7 +108,7 @@ jobs: # Build libQuotient as a shared library across platforms but also # check the static configuration somewhere CMAKE_ARGS="-G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfo \ - -DBUILD_SHARED_LIBS=${{ !matrix.sonar }} \ + -DBUILD_SHARED_LIBS=${{ !matrix.sonar && runner.os == 'Linux' }} \ -DCMAKE_INSTALL_PREFIX=~/.local \ -DCMAKE_PREFIX_PATH=~/.local \ -DCMAKE_INSTALL_RPATH_USE_LINK_PATH=ON" -- cgit v1.2.3