Age | Commit message (Collapse) | Author | |
---|---|---|---|
2017-05-09 | LeaveRoomJob now accepts a roomId, not a Room object; Room::leaveRoom() ↵ | Kitsune Ral | |
introduced; Connection and Room cleanup Helps to better encapsulate Room | |||
2017-05-09 | Code cleanup and tweaking (partially driven by clang-tidy) | Kitsune Ral | |
Mainly it's about const-ification (in particular, passing const-refs instead of values) and deleting unneeded declarations/#includes. Since the changes alter the external interface, this is submitted as a PR for peer review. One of unneeded declarations/definitions is a virtual destructor in BaseJob descendants. Since a job object should be deleted through QObject::deleteLater() anyway (and it's the only correct way of disposing of the object), all deletions will call the stack of destructors through virtual QObject::~QObject(). Therefore even BaseJob could get on with a non-virtual destructor but for the sake of clarity BaseJob::~BaseJob() is still declared virtual. | |||
2017-04-02 | Renamed JobHttpType to more fitting HttpVerb; removed Job from enum values | Kitsune Ral | |
2016-10-15 | BaseJob: Use saved parameters instead of overriding apiPath(), query() and ↵ | Kitsune Ral | |
data() in each job class | |||
2016-05-27 | Use 'override' keyword throughout job classes; constify apiPath(), query(), ↵ | Kitsune Ral | |
data() Thanks to CLang model. | |||
2016-05-27 | Set the object name for each job, to make it clear which job has failed | Kitsune Ral | |
And we don't need two log lines for timeouts. | |||
2016-04-05 | Imported the current source tree from Quaternion/lib. | Kitsune Ral | |