| Age | Commit message (Collapse) | Author |
|---|
|
toJson(SignedOneTimeKey) incorrectly generated a "signatures" key
mapped to an empty object when no signatures were in the C++ value.
Also: fallback keys have an additional flag that also has to be taken
into account when verifying signatures.
|
|
'performance-no-automatic-move' triggers on code where copy elision
normally takes place anyway. In fact, all cases it triggered on were
also subject to named return value optimisation (NRVO).
[skip ci]
|
|
Honestly, it was quite intuitive even without that, but in reality
there are implicit conversion under the wraps. This commit makes them
explicit, for clarity.
|
|
Also: leave a link at the place in the spec with power level defaults
to make it clear they are not invented out of thin air.
|
|
|
|
Also: make ImplPtr more flexible.
|
|
|
|
|
|
|
|
GCC (even 12.x) doesn't like when a template parameter is of
a pointer/reference type and dumps this warning. See also:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90670
|
|
|
|
...instead of tucking the template in filesourceinfo.cpp where it surely
will be forgotten.
|
|
|
|
|
|
|
|
|
|
This pertains to QUO_IMPLICIT and DECL_DEPRECATED_ENUMERATOR - both can
be used with no connection to Qt meta-type system (which is what
quotient_common.h is for).
|
|
make_array() has been introduced to cover for shortcomings on macOS and
Windows. These shortcomings are no more there, so we can just use the
standardrlibrary.
|
|
|
|
|
|
That `std::move(_data)` never worked because the passed object is
a precursor to RequestData, and RequestData always takes things by
const-ref or by value, never by rvalue. Also, explicit mention of
RequestData is unnecessary, as its constructors are implicit by design.
|
|
Also: add a Matrix chat badge.
[skip ci]
|
|
|
|
|
|
Also: build with Qt 6 first, so that it fails sooner.
|
|
Although Qt 5 didn't complain about that, you could never really use
sendToDevices() in its slot (or even invocable) capacity because
Qt's meta-type system could not handle move-only UsersToDevicesToEvents.
Qt 6 is more stringent; the build fails at trying to instantiate
QMetaType for that type (with a rather unhelpful error message thrown
by Clang, and more helpful but very verbose diagnostic from MSVC)
because it does not provide a copy constructor.
However, sendToDevice doesn't really need to have full-blown events
in that parameter; just the content of the event is equally fine.
This commit does exactly that: replaces UsersToDevicesToEvents with
UsersToDevicesToContent that contains QJsonObject's instead of
EventPtr's. The code around is updated accordingly.
Also: factor out the key event JSON creation from
makeMessageEventForSessionKey() because it's the same JSON for each
target device; the function therefore is called encryptSessionKeyEvent()
now.
|
|
- CodeQL analysis was executed on every job that ran Clang, humping
the total execution time by 10+ minutes alone. Now it only runs on
a single job.
- libolm is no more compiled but installed from the repo, along with
libssl-dev; and both are installed in the same transaction as ninja
and valgrind, shaving out one apt transaction
- One more Windows job has been added to test building with Qt 6.3.1
on that OS.
- Qt version is pushed earlier in the job matrix, as it becomes more
significant than the compiler for a given platform.
|
|
Qt 6 builds are allowed to fail for now.
|
|
Also, use MSVC 2019 on Windows.
|
|
Its platform has been lagging behind most of the time; but more
importantly, the value from its analysis is almost non-existent, with
just one considerable issue being identified over the recent year if not
more. These days we have clang-tidy and Sonar that are much better at
static code analysis.
[skip ci]
|
|
[skip ci]
|
|
CONTRIBUTING.md got bitrotten in quite a few places.
[skip ci]
|
|
|
|
It takes well over an hour to build the whole lineup for now; while
the single right fix for that is making quotest capable of running in
parallel, a few GCC jobs can be safely dropped for now (and we'll see
if they should be brought back when parallel quotest unleashes the CI).
|
|
...meaning, clients have to compile in C++20 mode too from now.
|
|
|
|
New:
- refresh tokens support (changes in login.* and registration.*;
RefreshJob);
- GetRelatingEvents[WithRelType[AndEventType]]Job
Changed space_hierarchy.*:
- childrenState is of type StateEvents now; limit and maxDepth are
(omittable) integers, not doubles.
- no more unused `stripped_state.h` file inclusion.
|
|
|
|
|
|
|
|
The latest GTAD no more emits public_rooms_chunk.h
(public_rooms_response.h already has the same definition), and skips on
PublicRoomsResponse structure that is never used.
|
|
|
|
|
|
This reimplements #558 in a more reliable way. Deconstruction of
AccountRegistry may (or may not, yay for static initialisation) occur
after deconstruction of QCoreApplication, in which case an attempt
to determine the directory for the state fails because it depends on
the application object existence.
|
|
Add GTAD as a submodule
|
|
Also: make all cloning for update-api shallow, for optimisation.
|
|
Code generation in libQuotient is pretty sensitive to GTAD version
(or even a particular commit at times); so it makes sense to have GTAD
as a submodule in order to control the revision CI uses.
(amended with the GTAD commit that uses the right yaml-cpp commit)
|
|
This only updates 3 files affected by the change in the previous commit.
|
|
Also: drop inlining PublicRoomResponse by the name because it's already
inlined by $ref before that. This configuration needs the latest GTAD
(revision 51c53ed3) to work correctly; earlier GTAD will produce FTBFS
code.
|
|
|
