aboutsummaryrefslogtreecommitdiff
path: root/user.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'user.cpp')
-rw-r--r--user.cpp331
1 files changed, 266 insertions, 65 deletions
diff --git a/user.cpp b/user.cpp
index c80ec883..308b217c 100644
--- a/user.cpp
+++ b/user.cpp
@@ -19,9 +19,11 @@
#include "user.h"
#include "connection.h"
+#include "room.h"
#include "avatar.h"
#include "events/event.h"
#include "events/roommemberevent.h"
+#include "jobs/setroomstatejob.h"
#include "jobs/generated/profile.h"
#include "jobs/generated/content-repo.h"
@@ -29,40 +31,178 @@
#include <QtCore/QRegularExpression>
#include <QtCore/QPointer>
#include <QtCore/QStringBuilder>
+#include <QtCore/QElapsedTimer>
#include <functional>
+#include <unordered_set>
using namespace QMatrixClient;
+using namespace std::placeholders;
+using std::move;
class User::Private
{
public:
+ static Avatar* makeAvatar(QUrl url);
+
Private(QString userId, Connection* connection)
- : userId(std::move(userId)), connection(connection)
- , avatar(connection, QIcon::fromTheme(QStringLiteral("user-available")))
+ : userId(move(userId)), connection(connection)
{ }
+ ~Private()
+ {
+ for (auto a: otherAvatars)
+ delete a;
+ }
QString userId;
- QString name;
- QString bridged;
Connection* connection;
- Avatar avatar;
- QPointer<UploadContentJob> avatarUploadJob = nullptr;
- void setAvatar(UploadContentJob* job, User* q);
+ QString mostUsedName;
+ QString bridged;
+ const QScopedPointer<Avatar> mostUsedAvatar { makeAvatar({}) };
+ QMultiHash<QString, const Room*> otherNames;
+ QHash<QUrl, Avatar*> otherAvatars;
+ QMultiHash<QUrl, const Room*> avatarsToRooms;
+
+ mutable int totalRooms = 0;
+
+ QString nameForRoom(const Room* r, const QString& hint = {}) const;
+ void setNameForRoom(const Room* r, QString newName, QString oldName);
+ QUrl avatarUrlForRoom(const Room* r, const QUrl& hint = {}) const;
+ void setAvatarForRoom(const Room* r, const QUrl& newUrl,
+ const QUrl& oldUrl);
+
+ void setAvatarOnServer(QString contentUri, User* q);
+
};
-User::User(QString userId, Connection* connection)
- : QObject(connection), d(new Private(std::move(userId), connection))
+Avatar* User::Private::makeAvatar(QUrl url)
{
- setObjectName(userId);
+ static const QIcon icon
+ { QIcon::fromTheme(QStringLiteral("user-available")) };
+ return new Avatar(url, icon);
+}
+
+QString User::Private::nameForRoom(const Room* r, const QString& hint) const
+{
+ // If the hint is accurate, this function is O(1) instead of O(n)
+ if (hint == mostUsedName || otherNames.contains(hint, r))
+ return hint;
+ return otherNames.key(r, mostUsedName);
+}
+
+static constexpr int MIN_JOINED_ROOMS_TO_LOG = 20;
+
+void User::Private::setNameForRoom(const Room* r, QString newName,
+ QString oldName)
+{
+ Q_ASSERT(oldName != newName);
+ Q_ASSERT(oldName == mostUsedName || otherNames.contains(oldName, r));
+ if (totalRooms < 2)
+ {
+ Q_ASSERT_X(totalRooms > 0 && otherNames.empty(), __FUNCTION__,
+ "Internal structures inconsistency");
+ mostUsedName = move(newName);
+ return;
+ }
+ otherNames.remove(oldName, r);
+ if (newName != mostUsedName)
+ {
+ // Check if the newName is about to become most used.
+ if (otherNames.count(newName) >= totalRooms - otherNames.size())
+ {
+ Q_ASSERT(totalRooms > 1);
+ QElapsedTimer et;
+ if (totalRooms > MIN_JOINED_ROOMS_TO_LOG)
+ {
+ qCDebug(MAIN) << "Switching the most used name of user" << userId
+ << "from" << mostUsedName << "to" << newName;
+ qCDebug(MAIN) << "The user is in" << totalRooms << "rooms";
+ et.start();
+ }
+
+ for (auto* r1: connection->roomMap())
+ if (nameForRoom(r1) == mostUsedName)
+ otherNames.insert(mostUsedName, r1);
+
+ mostUsedName = newName;
+ otherNames.remove(newName);
+ if (totalRooms > MIN_JOINED_ROOMS_TO_LOG)
+ qCDebug(PROFILER) << et.elapsed()
+ << "ms to switch the most used name";
+ }
+ else
+ otherNames.insert(newName, r);
+ }
}
-User::~User()
+QUrl User::Private::avatarUrlForRoom(const Room* r, const QUrl& hint) const
{
- delete d;
+ // If the hint is accurate, this function is O(1) instead of O(n)
+ if (hint == mostUsedAvatar->url() || avatarsToRooms.contains(hint, r))
+ return hint;
+ auto it = std::find(avatarsToRooms.begin(), avatarsToRooms.end(), r);
+ return it == avatarsToRooms.end() ? mostUsedAvatar->url() : it.key();
}
+void User::Private::setAvatarForRoom(const Room* r, const QUrl& newUrl,
+ const QUrl& oldUrl)
+{
+ Q_ASSERT(oldUrl != newUrl);
+ Q_ASSERT(oldUrl == mostUsedAvatar->url() ||
+ avatarsToRooms.contains(oldUrl, r));
+ if (totalRooms < 2)
+ {
+ Q_ASSERT_X(totalRooms > 0 && otherAvatars.empty(), __FUNCTION__,
+ "Internal structures inconsistency");
+ mostUsedAvatar->updateUrl(newUrl);
+ return;
+ }
+ avatarsToRooms.remove(oldUrl, r);
+ if (!avatarsToRooms.contains(oldUrl))
+ {
+ delete otherAvatars.value(oldUrl);
+ otherAvatars.remove(oldUrl);
+ }
+ if (newUrl != mostUsedAvatar->url())
+ {
+ // Check if the new avatar is about to become most used.
+ if (avatarsToRooms.count(newUrl) >= totalRooms - avatarsToRooms.size())
+ {
+ QElapsedTimer et;
+ if (totalRooms > MIN_JOINED_ROOMS_TO_LOG)
+ {
+ qCDebug(MAIN) << "Switching the most used avatar of user" << userId
+ << "from" << mostUsedAvatar->url().toDisplayString()
+ << "to" << newUrl.toDisplayString();
+ et.start();
+ }
+ avatarsToRooms.remove(newUrl);
+ auto* nextMostUsed = otherAvatars.take(newUrl);
+ std::swap(*mostUsedAvatar, *nextMostUsed);
+ otherAvatars.insert(nextMostUsed->url(), nextMostUsed);
+ for (const auto* r1: connection->roomMap())
+ if (avatarUrlForRoom(r1) == nextMostUsed->url())
+ avatarsToRooms.insert(nextMostUsed->url(), r1);
+
+ if (totalRooms > MIN_JOINED_ROOMS_TO_LOG)
+ qCDebug(PROFILER) << et.elapsed()
+ << "ms to switch the most used avatar";
+ } else {
+ otherAvatars.insert(newUrl, makeAvatar(newUrl));
+ avatarsToRooms.insert(newUrl, r);
+ }
+ }
+}
+
+User::User(QString userId, Connection* connection)
+ : QObject(connection), d(new Private(move(userId), connection))
+{
+ setObjectName(userId);
+}
+
+User::~User() = default;
+
QString User::id() const
{
return d->userId;
@@ -77,26 +217,41 @@ bool User::isGuest() const
return *it == ':';
}
-QString User::name() const
+QString User::name(const Room* room) const
{
- return d->name;
+ return d->nameForRoom(room);
}
-void User::updateName(const QString& newName)
+void User::updateName(const QString& newName, const Room* room)
{
- const auto oldName = name();
- if (oldName != newName)
+ updateName(newName, d->nameForRoom(room), room);
+}
+
+void User::updateName(const QString& newName, const QString& oldName,
+ const Room* room)
+{
+ Q_ASSERT(oldName == d->mostUsedName || d->otherNames.contains(oldName, room));
+ if (newName != oldName)
{
- d->name = newName;
+ emit nameAboutToChange(newName, oldName, room);
+ d->setNameForRoom(room, newName, oldName);
setObjectName(displayname());
- emit nameChanged(newName, oldName);
+ emit nameChanged(newName, oldName, room);
}
}
-void User::updateAvatarUrl(const QUrl& newUrl)
+void User::updateAvatarUrl(const QUrl& newUrl, const QUrl& oldUrl,
+ const Room* room)
{
- if (d->avatar.updateUrl(newUrl))
- emit avatarChanged(this);
+ Q_ASSERT(oldUrl == d->mostUsedAvatar->url() ||
+ d->avatarsToRooms.contains(oldUrl, room));
+ if (newUrl != oldUrl)
+ {
+ d->setAvatarForRoom(room, newUrl, oldUrl);
+ setObjectName(displayname());
+ emit avatarChanged(this, room);
+ }
+
}
void User::rename(const QString& newName)
@@ -105,41 +260,53 @@ void User::rename(const QString& newName)
connect(job, &BaseJob::success, this, [=] { updateName(newName); });
}
+void User::rename(const QString& newName, const Room* r)
+{
+ if (!r)
+ {
+ qCWarning(MAIN) << "Passing a null room to two-argument User::rename()"
+ "is incorrect; client developer, please fix it";
+ rename(newName);
+ }
+ Q_ASSERT_X(r->memberJoinState(this) == JoinState::Join, __FUNCTION__,
+ "Attempt to rename a user that's not a room member");
+ MemberEventContent evtC;
+ evtC.displayName = newName;
+ auto job = d->connection->callApi<SetRoomStateJob>(
+ r->id(), id(), RoomMemberEvent(move(evtC)));
+ connect(job, &BaseJob::success, this, [=] { updateName(newName, r); });
+}
+
bool User::setAvatar(const QString& fileName)
{
- if (isJobRunning(d->avatarUploadJob))
- return false;
- d->setAvatar(d->connection->uploadFile(fileName), this);
- return true;
+ return avatarObject().upload(d->connection, fileName,
+ std::bind(&Private::setAvatarOnServer, d.data(), _1, this));
}
bool User::setAvatar(QIODevice* source)
{
- if (isJobRunning(d->avatarUploadJob) || !source->isReadable())
- return false;
- d->setAvatar(d->connection->uploadContent(source), this);
- return true;
+ return avatarObject().upload(d->connection, source,
+ std::bind(&Private::setAvatarOnServer, d.data(), _1, this));
}
-void User::Private::setAvatar(UploadContentJob* job, User* q)
+void User::Private::setAvatarOnServer(QString contentUri, User* q)
{
- avatarUploadJob = job;
- connect(job, &BaseJob::success, q, [this,q] {
- auto* j = connection->callApi<SetAvatarUrlJob>(
- userId, avatarUploadJob->contentUri());
- connect(j, &BaseJob::success, q, [q] { emit q->avatarChanged(q); });
- });
+ auto* j = connection->callApi<SetAvatarUrlJob>(userId, contentUri);
+ connect(j, &BaseJob::success, q,
+ [=] { q->updateAvatarUrl(contentUri, avatarUrlForRoom(nullptr)); });
}
-QString User::displayname() const
+QString User::displayname(const Room* room) const
{
- return d->name.isEmpty() ? d->userId : d->name;
+ auto name = d->nameForRoom(room);
+ return name.isEmpty() ? d->userId :
+ room ? room->roomMembername(name) : name;
}
-QString User::fullName() const
+QString User::fullName(const Room* room) const
{
- return d->name.isEmpty() ? d->userId :
- d->name % " (" % d->userId % ')';
+ auto name = d->nameForRoom(room);
+ return name.isEmpty() ? d->userId : name % " (" % d->userId % ')';
}
QString User::bridged() const
@@ -147,48 +314,82 @@ QString User::bridged() const
return d->bridged;
}
-const Avatar& User::avatarObject() const
+const Avatar& User::avatarObject(const Room* room) const
{
- return d->avatar;
+ return *d->otherAvatars.value(d->avatarUrlForRoom(room),
+ d->mostUsedAvatar.data());
}
-QImage User::avatar(int dimension)
+QImage User::avatar(int dimension, const Room* room)
{
- return avatar(dimension, dimension);
+ return avatar(dimension, dimension, room);
}
-QImage User::avatar(int width, int height)
+QImage User::avatar(int width, int height, const Room* room)
{
- return d->avatar.get(width, height, [=] { emit avatarChanged(this); });
+ return avatar(width, height, room, []{});
}
-QString User::avatarMediaId() const
+QImage User::avatar(int width, int height, const Room* room,
+ Avatar::get_callback_t callback)
{
- return d->avatar.mediaId();
+ return avatarObject(room).get(d->connection, width, height,
+ [=] { emit avatarChanged(this, room); callback(); });
}
-QUrl User::avatarUrl() const
+QString User::avatarMediaId(const Room* room) const
{
- return d->avatar.url();
+ return avatarObject(room).mediaId();
}
-void User::processEvent(Event* event)
+QUrl User::avatarUrl(const Room* room) const
{
- if( event->type() == EventType::RoomMember )
+ return avatarObject(room).url();
+}
+
+void User::processEvent(RoomMemberEvent* event, const Room* room)
+{
+ if (event->membership() != MembershipType::Invite &&
+ event->membership() != MembershipType::Join)
+ return;
+
+ auto aboutToEnter = room->memberJoinState(this) == JoinState::Leave &&
+ (event->membership() == MembershipType::Join ||
+ event->membership() == MembershipType::Invite);
+ if (aboutToEnter)
+ ++d->totalRooms;
+
+ auto newName = event->displayName();
+ // `bridged` value uses the same notification signal as the name;
+ // it is assumed that first setting of the bridge occurs together with
+ // the first setting of the name, and further bridge updates are
+ // exceptionally rare (the only reasonable case being that the bridge
+ // changes the naming convention). For the same reason room-specific
+ // bridge tags are not supported at all.
+ QRegularExpression reSuffix(" \\((IRC|Gitter|Telegram)\\)$");
+ auto match = reSuffix.match(newName);
+ if (match.hasMatch())
{
- auto e = static_cast<RoomMemberEvent*>(event);
- if (e->membership() == MembershipType::Leave)
- return;
-
- auto newName = e->displayName();
- QRegularExpression reSuffix(" \\((IRC|Gitter|Telegram)\\)$");
- auto match = reSuffix.match(newName);
- if (match.hasMatch())
+ if (d->bridged != match.captured(1))
{
+ if (!d->bridged.isEmpty())
+ qCWarning(MAIN) << "Bridge for user" << id() << "changed:"
+ << d->bridged << "->" << match.captured(1);
d->bridged = match.captured(1);
- newName.truncate(match.capturedStart(0));
}
- updateName(newName);
- updateAvatarUrl(e->avatarUrl());
+ newName.truncate(match.capturedStart(0));
+ }
+ if (event->prevContent())
+ {
+ // FIXME: the hint doesn't work for bridged users
+ auto oldNameHint =
+ d->nameForRoom(room, event->prevContent()->displayName);
+ updateName(event->displayName(), oldNameHint, room);
+ updateAvatarUrl(event->avatarUrl(),
+ d->avatarUrlForRoom(room, event->prevContent()->avatarUrl),
+ room);
+ } else {
+ updateName(event->displayName(), room);
+ updateAvatarUrl(event->avatarUrl(), d->avatarUrlForRoom(room), room);
}
}